RFR: 8336856: Optimize String Concat [v23]

Shaojin Wen duke at openjdk.org
Fri Aug 2 01:35:43 UTC 2024


On Fri, 2 Aug 2024 01:04:08 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix performance regression caused by args.erase()
>
> I think erasing arguments is needed for correctness - are you sure this was cause for observed regressions? e2b30b3  backed out a few other things, too.

@cl4es What is the reason for `erasing arguments is needed for correctness`? The current version can handle non-Object type parameters, is it because of complexity?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20273#issuecomment-2264323333


More information about the core-libs-dev mailing list