RFR: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation [v8]

Adam Sotona asotona at openjdk.org
Fri Aug 2 13:55:37 UTC 2024


On Fri, 2 Aug 2024 00:04:48 GMT, Chen Liang <liach at openjdk.org> wrote:

>> `TypeAnnotation` is not an annotation, as it should not be used in places like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an annotation at a given location instead of to be an annotation.
>> 
>> Depends on #20205.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
> 
>  - remove compile, use element-value, break long sentences
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/typeanno-model
>  - Improve docs for repeating, default, and value name
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/typeanno-model
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/typeanno-model
>  - More refinements from alex
>  - Artifact -> construct
>  - More about Annotation, add equals note
>  - Further refine wording
>  - Refine the spec of TypeAnnotation per Alex feedback
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/f3707e9b...3a91a3a5

Marked as reviewed by asotona (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20247#pullrequestreview-2215642863


More information about the core-libs-dev mailing list