RFR: 8337506: Disable "best-fit" mapping on Windows command line [v2]

Alan Bateman alanb at openjdk.org
Tue Aug 6 03:04:33 UTC 2024


On Fri, 2 Aug 2024 18:40:07 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Fixing the Java launcher's command line argument parsing issue on Windows. The Java launcher on Windows has been using `GetCommandLineA()` to obtain arguments, which by default does "best-fit" mapping when the arguments are converted to ANSI code page encoding. By disabling this "best-fit" mapping, the launcher's parsing works as expected. A corresponding CSR has been drafted for the behavioral change.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment for the error case

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20428#pullrequestreview-2220183865


More information about the core-libs-dev mailing list