RFR: 8336856: Optimize String Concat [v32]

Claes Redestad redestad at openjdk.org
Tue Aug 6 17:32:35 UTC 2024


On Tue, 6 Aug 2024 17:01:11 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> This PR implements the same algorithm as the current generateMHInlineCopy based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix comments & code style

Did some debugging and I think this should be sufficient to resolve the WithSecurityManager test failure:


diff --git a/src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java b/src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java
index afb3d1374ab..fa47428d113 100644
--- a/src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java
+++ b/src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java
@@ -80,7 +80,7 @@ public static ClassFileDumper getInstance(String key, String path) {
     private final AtomicInteger counter = new AtomicInteger();

     private ClassFileDumper(String key, String path) {
-        String value = GetPropertyAction.privilegedGetProperty(key);
+        String value = VM.getSavedProperty(key);
         this.key = key;
         boolean enabled = value != null && value.isEmpty() ? true : Boolean.parseBoolean(value);
         if (enabled) {

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20273#issuecomment-2271794247


More information about the core-libs-dev mailing list