RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

Brian Burkhalter bpb at openjdk.org
Wed Aug 7 16:03:33 UTC 2024


On Wed, 7 Aug 2024 15:56:06 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge
>>  - 8337143: Removed dependency of libjava on headers in libnio/ch
>>  - 8337143: Move natives to <platform>/native/libjava/nio/{ch,fs} as a function of their original location in libnio
>>  - 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava
>
> make/modules/java.base/lib/CoreLibraries.gmk line 71:
> 
>> 69:         -framework Foundation \
>> 70:         -framework SystemConfiguration, \
>> 71:     LIBS_windows := advapi32.lib mswsock.lib ole32.lib shell32.lib version.lib ws2_32.lib, \
> 
> Are these libraries still required to build libnio, or can they be removed from that library now?

I will check. Thanks for noticing it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1707337157


More information about the core-libs-dev mailing list