RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

Daniel Fuchs dfuchs at openjdk.org
Thu Aug 8 16:42:38 UTC 2024


On Thu, 8 Aug 2024 16:21:30 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> I don't know - you added that code to Inet6AddressImpl - so presumably a test was failing without that code?
>> Which test was that? It wasn't obvious to me that adding code to load the "net" library would be required here.
>
> I'll have to investigate.

Possibly - if you made isIPv6Supported() in InetAddress.c return false, you might be able to see the issue in the same test that you observed failing without your change. 

InetAddress has a static block that will load the "net" library, and an other static block that will create the InetAddressImpl. It's a bit curious because I would expect the block that loads the "net" library to be executed before.

And the only place where I see Inet6AddressImpl being used is in that second static block in InetAddress.

I am not an expert on library loading though :-(

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1709897049


More information about the core-libs-dev mailing list