RFR: 8315884: New Object to ObjectMonitor mapping [v9]

Axel Boldt-Christmas aboldtch at openjdk.org
Mon Aug 12 14:41:23 UTC 2024


On Wed, 17 Jul 2024 06:48:03 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with 10 additional commits since the last revision:
>> 
>>  - Remove try_read
>>  - Add explicit to single parameter constructors
>>  - Remove superfluous access specifier
>>  - Remove unused include
>>  - Update assert message OMCache::set_monitor
>>  - Fix indentation
>>  - Remove outdated comment LightweightSynchronizer::exit
>>  - Remove logStream include
>>  - Remove strange comment
>>  - Fix javaThread include
>
> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 60:
> 
>> 58: 
>> 59: // ConcurrentHashTable storing links from objects to ObjectMonitors
>> 60: class ObjectMonitorWorld : public CHeapObj<MEMFLAGS::mtObjectMonitor> {
> 
> OMWorld describes the project not the hashtable, this should be called ObjectMonitorTable or some such.

I agree.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1713909770


More information about the core-libs-dev mailing list