RFR: 8338014: Improve usage of @jvms tags in class file API
Joe Darcy
darcy at openjdk.org
Mon Aug 12 18:52:33 UTC 2024
On Mon, 12 Aug 2024 18:42:45 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Hi all,
>>
>> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014) improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>>
>> Thanks,
>> Sonia
>
> src/java.base/share/classes/java/lang/classfile/attribute/SyntheticAttribute.java line 37:
>
>> 35:
>> 36: /**
>> 37: * Models the {@code Synthetic} attribute JVMS {@jvms 4.7.8}, which can appear on
>
> These occurrences should be `(JVMS {@jvms x.x.x})`.
I agree that structure would be better and more consistent with `@jmvs` usage elsewhere in core libs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20513#discussion_r1714232145
More information about the core-libs-dev
mailing list