RFR: 8336856: Optimize String Concat [v41]

[Chen Liang]

On Mon, 12 Aug 2024 16:16:10 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> This PR implements the same algorithm as the current generateMHInlineCopy based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - fix comments
>  - remove unused code

src/java.base/share/classes/java/lang/StringConcatHelper.java line 48:

> 46:         final int length;
> 47:         final byte coder;
> 48:         protected StringConcatBase(String[] constants) {

Suggestion:

        StringConcatBase(String[] constants) {

Package-private class. Also this feels a bit weird that this is not abstract, a bit of code smell...

src/java.base/share/classes/java/lang/invoke/MemberName.java line 961:

> 959:                     return null;
> 960:                 }
> 961:                 if (allowedModes != LM_TRUSTED) {

❌ You must revert changes to permission checks before a potential integration. This can involve security and massively increase the review complexity and risk of conformance violation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20273#discussion_r1714075309
PR Review Comment: https://git.openjdk.org/jdk/pull/20273#discussion_r1714070528