RFR: 8336856: Efficient hidden class-based string concatenation strategy [v48]

Shaojin Wen duke at openjdk.org
Tue Aug 13 09:00:10 UTC 2024


On Tue, 13 Aug 2024 08:04:07 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add jtreg HiddenClassUnloading
>
> test/jdk/java/lang/String/concat/HiddenClassUnloading.java line 67:
> 
>> 65:                     new Object[0]
>> 66:             );
>> 67:             MethodHandle mh = callSite.dynamicInvoker();
> 
> Actually invoking the concats seem unnecessary for this test; even with the rest of this method removed many thousands of classes is unloaded. We also seem to do pretty well with fewer iterations in the outer loop.

Yes, this is not necessary, it is there to check correctness, but it is not what this test is about, so I have removed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20273#discussion_r1714924871


More information about the core-libs-dev mailing list