RFR: 8336856: Efficient hidden class-based string concatenation strategy [v51]

Claes Redestad redestad at openjdk.org
Tue Aug 13 09:25:21 UTC 2024


On Tue, 13 Aug 2024 09:00:10 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> This PR implements the same algorithm as the current generateMHInlineCopy based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java
>   
>   Co-authored-by: Claes Redestad <claes.redestad at oracle.com>

src/java.base/share/classes/java/lang/StringConcatHelper.java line 121:

> 119:         @ForceInline
> 120:         String concat(Object value) {
> 121:             String str = stringOf(value);

Redundant (remove, or replace `stringOf(value)` on next line with `str`)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20273#discussion_r1714962672


More information about the core-libs-dev mailing list