RFR: 8315884: New Object to ObjectMonitor mapping [v16]

Daniel D. Daugherty dcubed at openjdk.org
Wed Aug 14 15:10:56 UTC 2024


On Wed, 14 Aug 2024 09:35:10 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> src/hotspot/share/runtime/vframe.cpp line 252:
>> 
>>> 250:           if (mark.has_monitor()) {
>>> 251:             ObjectMonitor* mon = ObjectSynchronizer::read_monitor(current, monitor->owner(), mark);
>>> 252:             if (// if the monitor is null we must be in the process of locking
>> 
>> nit - please add a space after `(`
>
> Should I align the rest of the lines? Adding the extra space here looks strange to me. But the inlined comments looks strange as well. This is all pre-existing code that just moved around a bit.

I'm just not fond of a `// comment` butting right against code.
Your call on whether to leave it alone or how to reformat it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1717114224


More information about the core-libs-dev mailing list