RFR: 8315884: New Object to ObjectMonitor mapping [v15]

Daniel D. Daugherty dcubed at openjdk.org
Wed Aug 14 21:08:00 UTC 2024


On Tue, 13 Aug 2024 17:24:19 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove the last OMWorld references
>>  - Rename omworldtable_work to object_monitor_table_work
>
> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 341:
> 
>> 339: 
>> 340: ObjectMonitor* LightweightSynchronizer::get_or_insert_monitor_from_table(oop object, JavaThread* current, bool* inserted) {
>> 341:   assert(LockingMode == LM_LIGHTWEIGHT, "must be");
> 
> Do you want to assert: `inserted != nullptr`?

What was the resolution? I don't see a reply or a change here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1717543005


More information about the core-libs-dev mailing list