RFR: 8338398: Trivially fix grammar and typos [v2]
Pavel Rappo
prappo at openjdk.org
Thu Aug 15 08:28:24 UTC 2024
> This PR fixes a few trivial grammar issues and typos in documentation.
>
> The main issue is the use of the word "timeout". To my mind, timeout, a duration, is not the same as deadline, which is a point in time, an instant, which allows "before" and "after". While one can think of timeout as of an event, which can occur, it usually expires, or elapses. An activity can also "time out" (phrasal verb).
>
> I think the proposed change might read better and match wording already used throughout `java.util.concurrent.**`, for example, here:
>
> * https://github.com/openjdk/jdk/blob/00e6c63cd12e3f92d0c1d007aab4f74915616ffb/src/java.base/share/classes/java/util/concurrent/ExecutorService.java#L211-L223
> * https://github.com/openjdk/jdk/blob/fbe4cc96e223882a18c7ff666fe6f68b3fa2cfe4/src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java#L1019-L1036
>
> @DougLea, thoughts?
Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
Fix grammatical tense
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20584/files
- new: https://git.openjdk.org/jdk/pull/20584/files/0c692020..3c05ab33
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20584&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20584&range=00-01
Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/20584.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20584/head:pull/20584
PR: https://git.openjdk.org/jdk/pull/20584
More information about the core-libs-dev
mailing list