RFR: 8338417: Explicitly pin a virtual thread before acquiring the JFR string pool monitor [v2]

Markus Grönlund mgronlun at openjdk.org
Thu Aug 15 09:54:24 UTC 2024


> Greetings,
> 
> Explicitly pin a virtual thread before acquiring the JFR string pool monitor because migrating a carrier thread local event writer object onto another carrier thread is impossible.
> 
> During event commit, the thread is in a critical section because it has loaded a carrier thread local event writer object. For virtual threads, a contended monitor, such as a synchronized block, is a point where a thread could become unmounted.
> 
> A monitor guards the JFR string pool, but remounting a virtual thread onto another carrier is impossible because of the event writer.
> 
> Therefore, it's imperative to use explicit pin constructs to prevent unmounting at this location. 
> 
> Testing: jdk_jfr
> 
> Thanks
> Markus

Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:

  hoist pinVirtualThread

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20588/files
  - new: https://git.openjdk.org/jdk/pull/20588/files/6a63f340..b047b95c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20588&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20588&range=00-01

  Stats: 4 lines in 1 file changed: 2 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20588.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20588/head:pull/20588

PR: https://git.openjdk.org/jdk/pull/20588


More information about the core-libs-dev mailing list