RFR: 8338406: BytecodeHelpers using wrong bootstrap method descriptor for condy

Adam Sotona asotona at openjdk.org
Thu Aug 15 14:50:49 UTC 2024


On Wed, 14 Aug 2024 17:07:21 GMT, Chen Liang <liach at openjdk.org> wrote:

> `BytecodeHelpers.handleConstantDescToHandleInfo` is incorrectly using `DirectMethodHandleDesc.invocationType`, which accidentally works for static bootstrap methods so it's discovered only now with more extensive testing from bytebuddy. Cleaned up by reusing the correct `handleDescToHandleInfo` instead. Thanks to @raphw for the report.
> 
> For now, a workaround can be instead of using `DynamicConstantDesc`, translate to `ConstantDynamicEntry` in user applications.

Looks good to me, thanks for the fix.

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20586#pullrequestreview-2240563027


More information about the core-libs-dev mailing list