Integrated: 8338398: Trivially fix grammar and typos
Pavel Rappo
prappo at openjdk.org
Fri Aug 16 14:08:53 UTC 2024
On Wed, 14 Aug 2024 13:38:34 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
> This PR fixes a few trivial grammar issues and typos in documentation.
>
> The main issue is the use of the word "timeout". To my mind, timeout, a duration, is not the same as deadline, which is a point in time, an instant, which allows "before" and "after". While one can think of timeout as of an event, which can occur, it usually expires, or elapses. An activity can also "time out" (phrasal verb).
>
> I think the proposed change might read better and match wording already used throughout `java.util.concurrent.**`, for example, here:
>
> * https://github.com/openjdk/jdk/blob/00e6c63cd12e3f92d0c1d007aab4f74915616ffb/src/java.base/share/classes/java/util/concurrent/ExecutorService.java#L211-L223
> * https://github.com/openjdk/jdk/blob/fbe4cc96e223882a18c7ff666fe6f68b3fa2cfe4/src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java#L1019-L1036
>
> @DougLea, thoughts?
This pull request has now been integrated.
Changeset: 07352c67
Author: Pavel Rappo <prappo at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/07352c67448f3f35827395c83ac95e3ca0e4c6bc
Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod
8338398: Trivially fix grammar and typos
Reviewed-by: aivanov
-------------
PR: https://git.openjdk.org/jdk/pull/20584
More information about the core-libs-dev
mailing list