RFR: 8338532: Speed up the ClassFile API MethodTypeDesc#ofDescriptor

[Claes Redestad]

On Fri, 16 Aug 2024 17:06:38 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> test/micro/org/openjdk/bench/java/lang/classfile/MethodTypeDescBench.java line 23:
>> 
>>> 21:  * questions.
>>> 22:  */
>>> 23: package org.openjdk.bench.java.lang.classfile;
>> 
>> Wrong package as the code being tested is in java.lang.constant. Also there is already a related microbenchmark in org.openjdk.bench.java.lang.constant.MethodTypeDescFactories - can you check if that covers your needs?
>
> MethodTypeDescFactories has some illegal MethodTypeDesc, and throwing exceptions will affect the performance comparison of normal scenarios.

Not intentionally - which one is illegal? Or are you thinking about the dots? Those are replaced with the descriptorString of the benchmark class before execution. Just a trick to allow testing really long descriptor strings without making the parameter output humongous.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20611#discussion_r1720164037