RFR: 8338532: Speed up the ClassFile API MethodTypeDesc#ofDescriptor [v2]

Chen Liang liach at openjdk.org
Mon Aug 19 23:28:52 UTC 2024


On Mon, 19 Aug 2024 23:14:06 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> The current implementation of ofDescriptor puts return type and parameter types together in an ArrayList, and then splits them into return type and array of parameter types. This ArrayList creation is unnecessary, considering most descriptors only have few parameter types.
>> 
>> By splitting return type and parameter types separately and scanning the descriptor first to get the number of parameters, we can just allocate an exact, trusted array for the resulting MethodTypeDesc without copy.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   less changes with suggestions from @liach

Thanks for the cleanup. Looks good to me, but I prefer another engineer to review too.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20611#pullrequestreview-2246702272


More information about the core-libs-dev mailing list