RFR: 8336275: Move common Method and Constructor fields to Executable [v3]
Coleen Phillimore
coleenp at openjdk.org
Wed Aug 21 16:47:05 UTC 2024
On Wed, 21 Aug 2024 15:42:18 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Move fields common to Method and Field to executable, which simplifies implementation. Removed useless transient modifiers as Method and Field were never serializable.
>>
>> Note to core-libs reviewers: Please review the associated CSR on trivial removal of `abstract` modifier as well.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>
> - Fix after merge
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/executable-inline
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/executable-inline
> - Redundant transient; Update the comments to be more accurate
> - Inline some common ctor + method fields to executable
The hotspot code looks okay, but I have a couple of small cleanup requests in the changes.
-------------
Changes requested by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20188#pullrequestreview-2251378680
More information about the core-libs-dev
mailing list