RFR: 8338546: Speed up ConstantPoolBuilder::classEntry(ClassDesc) [v2]

[Claes Redestad]

On Thu, 22 Aug 2024 12:50:24 GMT, Chen Liang <liach at openjdk.org> wrote:

>> test/micro/org/openjdk/bench/jdk/classfile/ConstantPoolBuildingClassEntry.java line 64:
>> 
>>> 62:         builder = ConstantPoolBuilder.of();
>>> 63:         classDescs = List.of(
>>> 64:                 CD_Byte, CD_Object, CD_Long.arrayType(), CD_String, CD_String, CD_Object, CD_Short,
>> 
>> Should this include some primitive class descs? I only see wrapper types like `CD_Integer`
>
> Unfortunately primitive types aren't encoded by class entries, but accessed by getstatic on Wrapper's TYPE field.

Ok, good. Maybe add a comment that this collection of descs deliberately omits primitive types since they would not usually end up in this code?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20667#discussion_r1727068272