RFR: 8338546: Speed up ConstantPoolBuilder::classEntry(ClassDesc) [v2]
Claes Redestad
redestad at openjdk.org
Thu Aug 22 14:38:03 UTC 2024
On Thu, 22 Aug 2024 13:51:52 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Ok, good. Maybe add a comment that this collection of descs deliberately omits primitive types since they would not usually end up in this code?
>
> Uh, I mean it's a class entry... and class file format prohibits primitives in class entries. I would deduce that information from the benchmark name.
Yes, obvious in hind-sight, but comments are good to remind readers of context that might not be obvious at a glance or without paging in the full context.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20667#discussion_r1727181581
More information about the core-libs-dev
mailing list