RFR: 8338728: Misc issues in memory layout javadoc [v2]

Per Minborg pminborg at openjdk.org
Fri Aug 23 13:49:02 UTC 2024


On Wed, 21 Aug 2024 13:24:15 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR fixes two minor issues in the `MemoryLayout` javadoc:
>> * the section describing dereference path talks about `P` and `P'` but then only uses `P` in the code;
>> * the `ceilDiv` math on the `PathElement::sequenceElement(long, long)` is wrong, as the division returns a negative number for F < 0, which is incorrect
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   * Clarify javadoc for var handles with dereference path elements
>   * Add test where dereference path element is last element in path

LGTM. Nice with a test even though just for documentation validation.

-------------

Marked as reviewed by pminborg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20659#pullrequestreview-2257299547


More information about the core-libs-dev mailing list