RFR: 8339120: Use more fine-granular gcc unused warnings [v3]

[Kim Barrett]

On Wed, 28 Aug 2024 13:02:55 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, we issue -Wno-unused for all files in gcc, which is a rather big sledgehammer to get rid of some warnings that proliferate in a few areas of the build.
>> 
>> We should instead leave -Wunused turned on (as done by -Wall) and use a much more fine-grained approach to disabling specific warnings in specific files or libraries.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix aarch54

Changes requested by kbarrett (Reviewer).

make/modules/java.desktop/lib/ClientLibraries.gmk line 284:

> 282: 
> 283: ifeq ($(USE_EXTERNAL_HARFBUZZ), true)
> 284:   LIBFONTMANAGER_EXTRA_SRC =

I think this 3space -> 2space indentation change shouldn't be part of this PR, esp. since 3space is
used in other parts of this file.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20733#pullrequestreview-2266289452
PR Review Comment: https://git.openjdk.org/jdk/pull/20733#discussion_r1734691445