RFR: 8339167: Remove AbstractPoolEntry.PrimitiveEntry to reduce boxing overheads

Chen Liang liach at openjdk.org
Wed Aug 28 16:24:20 UTC 2024


On Wed, 28 Aug 2024 14:27:45 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> Removing PrimitiveEntry reduces boxing/unboxing and removes a class.

Changes requested by liach (Reviewer).

src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java line 1079:

> 1077: 
> 1078:         FloatEntryImpl(ConstantPool cpm, int index, float f) {
> 1079:             super(cpm, ClassFile.TAG_FLOAT, index, Float.hashCode(f));

Suggestion:

            super(cpm, ClassFile.TAG_FLOAT, index, hash1(ClassFile.TAG_FLOAT, Float.hashCode(f)));

-------------

PR Review: https://git.openjdk.org/jdk/pull/20749#pullrequestreview-2266744670
PR Review Comment: https://git.openjdk.org/jdk/pull/20749#discussion_r1734971814


More information about the core-libs-dev mailing list