RFR: 8338716: Re-visit "interrupt handling" in jdk.internal.loader.Resource [v2]

Alan Bateman alanb at openjdk.org
Wed Aug 28 18:42:21 UTC 2024


On Wed, 28 Aug 2024 18:35:32 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> The InterruptibleIO feature (which was only on Solaris) was removed some time ago. See [JDK-4385444](https://bugs.openjdk.org/browse/JDK-4385444).
>> 
>> Vestiges of it remain in jdk.internal.loader.Resource.getBytes(), and should be removed.
>
> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move getContentLength() inside try block

I think this looks okay. I suspect the catching of IOException from close can be removed too but we don't have to do that now.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20736#pullrequestreview-2267010682


More information about the core-libs-dev mailing list