RFR: 8339115: Rename TypeKind enum constants to follow code style [v2]

Chen Liang liach at openjdk.org
Wed Aug 28 20:53:14 UTC 2024


> `TypeKind` enum constants are named in wrong code style; correct them before finalization.
> 
> Also improved `TypeKind` specification to talk about not mentioned `returnType`, `void`, and subword types being erased to int (and how). See the associated CSR too.
> 
> See the HTML output for the changed `JSpec` taglet's `6.5.newarray` rendering: https://cr.openjdk.org/~liach/8339115-typekind/java.base/java/lang/classfile/TypeKind.html
> 
> Note: when reviewing, please use https://cr.openjdk.org/~iris/se/23/spec/draft/java-se-23-draft-spec-37/ instead of JVMS 22 for reference; JVMS 23 has fixed a few ambiguities about subword types being absent from JVM's stack and locals.

Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - More fixes, reorder constants
 - Merge branch 'master' of https://github.com/openjdk/jdk into fix/typekind
 - 8339115: Rename TypeKind enum constants to follow code style

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20737/files
  - new: https://git.openjdk.org/jdk/pull/20737/files/f686716f..b7c499fa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20737&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20737&range=00-01

  Stats: 3432 lines in 65 files changed: 2324 ins; 537 del; 571 mod
  Patch: https://git.openjdk.org/jdk/pull/20737.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20737/head:pull/20737

PR: https://git.openjdk.org/jdk/pull/20737


More information about the core-libs-dev mailing list