RFR: 8339132: Make DirectCodeBuilder write through without allocating instruction objects [v3]
Adam Sotona
asotona at openjdk.org
Thu Aug 29 07:30:21 UTC 2024
On Wed, 28 Aug 2024 21:14:50 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Make `DirectCodeBuilder` write instructions actually directly without allocating extra objects. This speed up a lot of simple Class-File building cases that never go through intermediate transforms.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Remove redundant qualification, avoid boxing in b/sipush validation
> - Merge branch 'master' of https://github.com/openjdk/jdk into exp/cob-direct-methods
> - Use uppercase L for long literals
>
> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
> - Moar fixes
> - More direct code builder
Looks good to me.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20738#pullrequestreview-2267897550
More information about the core-libs-dev
mailing list