RFR: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java

[Lance Andersen]

On Wed, 28 Aug 2024 11:12:42 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this test-only PR which addresses several issues with the `test/jdk/java/util/zip/Available.java` test:
> 
> * The test is converted to JUnit 5
> * The test now creates its own test vector programmatically instead of relying on a binary `input.jar` test vector 
> * Coverage is added for calling `available()` after calling `ZipInputStream.closeEntry`, as expected by the API specification for `ZipInputStream.available`
> * Coverage is added for calling `available()` on a closed `ZipInputStream`
> * Coverage is added for the unspecified, but long-standing behavior of `ZipFileInputStream.available()` (The InputStream returned for `STORED` entries)
> 
> Additionally, the test is split into multiple methods, adding javadoc comments for each of them.

test/jdk/java/util/zip/Available.java line 147:

> 145:         }
> 146:     }
> 147: 

Could we collapse the two above tests  via


@ParameterizedTest
@ValueSource(strings = { "stored.txt", "delated.txt" })
void testAvailbleRemainingBytes(iString zipEntry) {
    try (ZipFile zfile = new ZipFile(zip.toFile())) {
            assertRemainingUncompressedBytes(zfile, zipEntry);
        }
}

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20744#discussion_r1736635196