RFR: 8333377: Migrate Generic Signature parsing to ClassFile API [v2]
Chen Liang
liach at openjdk.org
Fri Aug 30 02:23:22 UTC 2024
On Thu, 6 Jun 2024 18:48:58 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Core reflection's generic signature parsing uses an ancient library with outdated visitor pattern on a tree model and contains unnecessary boilerplates. This is a duplication of ClassFile API's signature model. We should just move to ClassFile API, which is more throughoutly tested as well.
>>
>> To ensure compatibility, new tests are added to ensure consistent behavior when encountering malformed signatures or signatures with missing types. The reflective objects have been preserved and the only change is that lazy expansion now happens from CF objects, to reduce compatibility risks.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/new-generic-info
> - Remove redundant try-catch in getEnclosingMethod/Constructor
> - Merge branch 'test/signature-error' into feature/new-generic-info
> - Fix everything
> - Fixxes
> - Stage
> - Stage new tests
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/new-generic-info
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/new-generic-info
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/new-generic-info
> - ... and 6 more: https://git.openjdk.org/jdk/compare/2a37764e...19ee8797
This is becoming more necessary as valhalla brings changes to signature format.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19281#issuecomment-2319704590
More information about the core-libs-dev
mailing list