RFR: 8339156: Use more fine-granular clang unused warnings

[Alan Bateman]

On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Currently, we issue -Wno-unused for all files in clang, which is a rather big sledgehammer to get rid of some warnings that proliferate in a few areas of the build.
> 
> We should instead leave -Wunused turned on (as done by -Wall) and use a much more fine-grained approach to disabling specific warnings in specific files or libraries.
> 
> This is similar to what has been done for gcc in JDK-8339120.

I wonder if there should be JBS issues for the specific source files/warnings so they can be looked at more closely (or maybe you've looked at them all already). Just wondering about the maintainability of DISABLED_WARNINGS_xxx values that list specific files as I assume they can bit rot quickly.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20770#issuecomment-2320021124