RFR: 8339260: Move rarely used constants out of ClassFile [v2]

Chen Liang liach at openjdk.org
Fri Aug 30 18:35:52 UTC 2024


> Many constants are cluttered in `ClassFile`. However, only a few of them are ever used by regular users, most notably `ACC_` flags and `JAVA_X_VERSION` constants. All other constants are specific and should live in more local locations, such as getters that return these constants.
> 
> This simplification of `ClassFile` constants improves user onramp to the Class-File API.
> 
> Notably, before, if `ClassFile` is static imported, `Opcode` enums must be qualified due to name clashes; this relocation allows `Opcode` enums to be static imported with `ACC_` flags, improving class file writing user experience.

Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:

 - Merge branch 'master' of https://github.com/openjdk/jdk into fix/constant-moving
 - Compile errors; now tests are all green.
 - Move Constant Pool tags to PoolEntry
   
   Two unexpected usages in jlink raw processing, but rest is fine
 - opcode values moved to OpcodeValues
   
   less impactful than imagined, no longer need to qualify Opcode use when star importing ClassFile
 - Hide default class flags as well
 - Simplify SimpleVerificationTypeInfo's constant names
 - 8339260: Move rarely used constants out of ClassFile

-------------

Changes: https://git.openjdk.org/jdk/pull/20773/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20773&range=01
  Stats: 2615 lines in 36 files changed: 865 ins; 905 del; 845 mod
  Patch: https://git.openjdk.org/jdk/pull/20773.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20773/head:pull/20773

PR: https://git.openjdk.org/jdk/pull/20773


More information about the core-libs-dev mailing list