RFR: 8337279: Optimize format instant [v7]
Stephen Colebourne
scolebourne at openjdk.org
Sat Aug 31 08:48:21 UTC 2024
On Tue, 27 Aug 2024 23:49:50 GMT, Shaojin Wen <swen at openjdk.org> wrote:
>> By removing the redundant code logic in DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>
> - Speed up Instant.toString using JavaTimeAccess
> - add JavaTimeAccess SharedSecrets
> - Merge remote-tracking branch 'upstream/master' into optim_instant_fmt_202407
> - breaking out the printNano methods
> - copyright
> - Update src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
>
> Co-authored-by: Stephen Colebourne <scolebourne at joda.org>
> - 1. fix handle fraction == -1
> 2. Split two methods to make codeSize less than 325
> - add comment
> - optimize format instant
The change looks OK from my perspective, however I would want someone with experience of `SharedSecrets` to comment
-------------
PR Review: https://git.openjdk.org/jdk/pull/20353#pullrequestreview-2273791076
More information about the core-libs-dev
mailing list