RFR: 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog [v2]
Roger Riggs
rriggs at openjdk.org
Mon Dec 2 18:22:38 UTC 2024
On Sat, 30 Nov 2024 19:47:15 GMT, Joe Wang <joehw at openjdk.org> wrote:
>> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>
> list files vertically
lookg good
src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java line 1217:
> 1215: resourceIdentifier.setExpandedSystemId(expandedSystemId);
> 1216: xmlInputSource = fEntityResolver.resolveEntity(resourceIdentifier);
> 1217: resolveByResolver = (xmlInputSource != null) ? true : false;
The "? true : false" isn't needed; the boolean result is sufficient.
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22465#pullrequestreview-2473520264
PR Review Comment: https://git.openjdk.org/jdk/pull/22465#discussion_r1866361223
More information about the core-libs-dev
mailing list