RFR: 8345353: Test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog

[Roger Riggs]

On Tue, 3 Dec 2024 02:22:15 GMT, Joe Wang <joehw at openjdk.org> wrote:

> Add test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog

Marked as reviewed by rriggs (Reviewer).

test/jaxp/javax/xml/jaxp/unittest/common/jdkcatalog/JDKCatalogTest.java line 217:

> 215:             if (line.contains(SYSTEM_ID)) {
> 216:                 line = line.replace(SYSTEM_ID, systemId);
> 217:             }

The `if ... contains ...` isn't necessary; String.replace is a no-op if the string is not present.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22506#pullrequestreview-2476637938
PR Review Comment: https://git.openjdk.org/jdk/pull/22506#discussion_r1868296245