Integrated: 8343839: Detect patched modules and abort run-time image link early
Severin Gehwolf
sgehwolf at openjdk.org
Tue Dec 3 20:44:55 UTC 2024
On Tue, 12 Nov 2024 11:00:36 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
> Please review this fix to how patched modules are being handled when linking from the run-time image. During review of [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed out that module patching should be detected earlier and the link should get aborted in that case.
>
> This patch implements it, by using `ModuleBootstrap.patcher().hasPatches()`. After this patch module patching is being detected before any archives are being read or the actual linking process starts (contrary to the previous solution).
>
> Testing:
> - [x] GHA testing (mac aarch64 test failures are infra related)
> - [x] Local testing of existing test, which covers it
>
> Thoughts?
This pull request has now been integrated.
Changeset: 05ee562a
Author: Severin Gehwolf <sgehwolf at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/05ee562a38bf7325becdd04f2e9d3238b95a4cb0
Stats: 131 lines in 9 files changed: 10 ins; 101 del; 20 mod
8343839: Detect patched modules and abort run-time image link early
Reviewed-by: mchung
-------------
PR: https://git.openjdk.org/jdk/pull/22037
More information about the core-libs-dev
mailing list