RFR: 8344540: Remove superseded wildcard description from java manpage [v4]

David Holmes dholmes at openjdk.org
Wed Dec 4 01:56:39 UTC 2024


On Tue, 3 Dec 2024 10:43:20 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this follow-up PR to improve `java`'s manpage section about wildcards in argument files: the confusing sentence is now removed.
>> 
>> This is a cleanup of commit https://github.com/openjdk/jdk/commit/5cb0d438231383d491b2fcca455d09af7f2ee016
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update java.md
>   
>   [skip ci]

Couple more nits sorry.

src/java.base/share/man/java.md line 3077:

> 3075: 
> 3076: -   The launcher doesn't expand wildcards that are present within an argument
> 3077:     file. That means an asterisk `*` is passed on as-is to the starting VM.

Suggestion:

    file. That means an asterisk (`*`) is passed on as-is to the starting VM.

src/java.base/share/man/java.md line 3079:

> 3077:     file. That means an asterisk `*` is passed on as-is to the starting VM.
> 3078:     For example `*.java` stays `*.java` and is not expanded to `Foo.java`,
> 3079:     `Bar.java ...`, as would happen with some command line shells.

The list was intended to be contiguous - no commas: 'Foo.java Bar.java ...' as that is how it would be expanded by the shell.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22236#pullrequestreview-2477092293
PR Review Comment: https://git.openjdk.org/jdk/pull/22236#discussion_r1868586170
PR Review Comment: https://git.openjdk.org/jdk/pull/22236#discussion_r1868587431


More information about the core-libs-dev mailing list