RFR: 8345403: Add more randomized tests to better cover FloatingDecimal parsing

Raffaello Giulietti rgiulietti at openjdk.org
Wed Dec 4 10:05:38 UTC 2024


On Wed, 4 Dec 2024 00:29:00 GMT, Chen Liang <liach at openjdk.org> wrote:

>> `jdk.internal.math.FloatingDecimal` parsing is mostly exercised on inputs produced by `Float.toString` and `Double.toString`, but should be extended on more random inputs.
>
> test/jdk/jdk/internal/math/FloatingDecimal/TestRandomFloatingDecimal.java line 36:
> 
>> 34: import static org.junit.jupiter.api.Assertions.assertEquals;
>> 35: 
>> 36: /**
> 
> Suggestion:
> 
> /*
> 
> Jtreg directives is usually formatted as block comments, and is often placed between license header and package/imports.

Copy&paste "error"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22523#discussion_r1869113178


More information about the core-libs-dev mailing list