RFR: 8343704: Bad GC parallelism with processing Cleaner queues [v17]

Aleksey Shipilev shade at openjdk.org
Wed Dec 4 11:40:01 UTC 2024


On Tue, 3 Dec 2024 07:31:14 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc linked list with segmented list of arrays. Arrays are easy targets for GC. There are possible improvements here, most glaring is parallelism that is currently knee-capped by global synchronization. The synchronization scheme follows what we have in original code, and I think it is safer to continue with it right now.
>> 
>> I'll put performance data in a separate comment.
>> 
>> Additional testing:
>>  - [x] Original reproducer improves drastically
>>  - [x] New microbenchmark shows no regression on "churning" tests, which covers insertion/removal perf
>>  - [x] New microbenchmark shows improvement on Full GC times (crude, but repeatable), serves as a proxy for reproducer
>>  - [x] `java/lang/ref` tests in release 
>>  - [x] `all` tests in fastdebug
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8343704-cleaner-gc
>  - Locals for head.size
>  - Merge branch 'master' into JDK-8343704-cleaner-gc
>  - Improve CleanerGC benchmark
>  - Check all elements are removable after random test
>  - Use RandomFactory in test
>  - Touchups
>  - Merge branch 'master' into JDK-8343704-cleaner-gc
>  - Drop --add-exports from the test
>  - prev is not needed
>  - ... and 9 more: https://git.openjdk.org/jdk/compare/f28ce14e...39184f94

There we go.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22043#issuecomment-2517076793


More information about the core-libs-dev mailing list