RFR: 8316804: Gracefully handle the case where --release is not specified last [v2]

[Jan Lahoda]

On Wed, 13 Nov 2024 16:08:44 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this change for the `jar` tool to gracefully handle the case where `--release` is not specified as the last arguments.
>> 
>> Prior to this commit, operation modes `-d --describe-module` and `--validate` expected to read the optional `--release` option as a file argument: `jar -d -f a.jar --release 9`
>> By adding a hidden GNU-style `--release` option, processing the optional arguments before in those two operation modes, the position is now no longer required to trail behind the `-f --file` option: `jar -d --release 9 -f a.jar`
>> 
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR
>>    jtreg:test/jdk/tools/jar                             26    26     0     0
>> ==============================
>> TEST SUCCESS
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Stream argument processing and fix typo

To me, this seems to make sense. I would probably suggest to add a test verifying the `--release` is still positional when creating the jar (as opposed to "global" for `--describe-module`), unless such a test already exists.

Any insights @jaikiran ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22079#issuecomment-2517189799