RFR: 8341551: Revisit jdk.internal.loader.URLClassPath.JarLoader after JEP 486 [v3]

Jaikiran Pai jpai at openjdk.org
Wed Dec 4 16:46:17 UTC 2024


On Wed, 4 Dec 2024 16:35:09 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Lance's suggestion - better comment on the method
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 665:
> 
>> 663:                 return jar;
>> 664:             }
>> 665:             if (!zipAccess.startsWithLocHeader(jar)) {
> 
> Suggestion:
> 
>             if (JAR_CHECKING_ENABLED && !zipAccess.startsWithLocHeader(jar)) {

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22545#discussion_r1869921795


More information about the core-libs-dev mailing list