RFR: 8345294: test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java timeout with JTREG_TEST_THREAD_FACTORY=Virtual

[Doug Lea]

On Wed, 4 Dec 2024 16:05:02 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Accommodate compensations when checking for missed signals; add a better test for this.
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2016:
> 
>> 2014:                 return awaitWork(w, p);       // block, drop, or exit
>> 2015:             if ((q = qs[k & (n - 1)]) == null)
>> 2016:                 Thread.onSpinWait();          // interleave spins and rechecks
> 
> Suggestion:
> 
>                 Thread.onSpinWait();

OK. I also adjusted overview docs to not say it is restricted to external queues.

> test/jdk/java/lang/Thread/virtual/Starvation.java line 1:
> 
>> 1: /* @test
> 
> Suggestion:
> 
> /*
>  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  *
>  * This code is free software; you can redistribute it and/or modify it
>  * under the terms of the GNU General Public License version 2 only, as
>  * published by the Free Software Foundation.
>  *
>  * This code is distributed in the hope that it will be useful, but WITHOUT
>  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
>  * version 2 for more details (a copy is included in the LICENSE file that
>  * accompanied this code).
>  *
>  * You should have received a copy of the GNU General Public License version
>  * 2 along with this work; if not, write to the Free Software Foundation,
>  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
>  *
>  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
>  * or visit www.oracle.com if you need additional information or have any
>  * questions.
>  */
>  
> /* @test

Oops. Thanks.

> test/jdk/java/lang/Thread/virtual/Starvation.java line 2:
> 
>> 1: /* @test
>> 2:  * @library /test/lib
> 
> Suggestion:
> 
>  * @bug 8345294
>  * @library /test/lib

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22543#discussion_r1870119162
PR Review Comment: https://git.openjdk.org/jdk/pull/22543#discussion_r1870119827
PR Review Comment: https://git.openjdk.org/jdk/pull/22543#discussion_r1870120171