RFR: 8341551: Revisit jdk.internal.loader.URLClassPath.JarLoader after JEP 486 [v5]

Jaikiran Pai jpai at openjdk.org
Thu Dec 5 04:38:04 UTC 2024


> Can I please get a review of this change which proposes to address https://bugs.openjdk.org/browse/JDK-8341551? 
> 
> The primary work in this PR is the specification of the previously existing `sun.misc.URLClassPath.disableJarChecking` system property and how the internal implementation of `java.net.URLClassLoader` treats it. The complete details about this property is available in the CSR for this change here https://bugs.openjdk.org/browse/JDK-8345394.
> 
> A new jtreg test has been introduced to exercise the usage of this system property.

Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - simplify system property check
 - fix URL creation to address failures on Windows OS
 - merge latest from master branch
 - Roger's suggestion - reduce "if" blocks
 - Lance's suggestion - better comment on the method
 - improve code comment
 - introduce a test for the sun.misc.URLClassPath.disableJarChecking system property
 - 8341551: Revisit jdk.internal.loader.URLClassPath.JarLoader after JEP 486

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22545/files
  - new: https://git.openjdk.org/jdk/pull/22545/files/c185c65e..b2d8bfee

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22545&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22545&range=03-04

  Stats: 4861 lines in 227 files changed: 1052 ins; 2885 del; 924 mod
  Patch: https://git.openjdk.org/jdk/pull/22545.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22545/head:pull/22545

PR: https://git.openjdk.org/jdk/pull/22545


More information about the core-libs-dev mailing list