RFR: 8345294: test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java timeout with JTREG_TEST_THREAD_FACTORY=Virtual [v3]

Alan Bateman alanb at openjdk.org
Thu Dec 5 10:36:43 UTC 2024


On Wed, 4 Dec 2024 19:24:20 GMT, Doug Lea <dl at openjdk.org> wrote:

>> Accommodate compensations when checking for missed signals; add a better test for this.
>
> Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into JDK-8345294
>  - Merge branch 'openjdk:master' into JDK-8345294
>  - Address review comments
>  - test starvation with monitors
>  - Accommodate uncompensates in deactivate

At some point we can add @Summary to the test as reminder of its purpose. Otherwise this looks good, and happy this was caught.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22543#pullrequestreview-2481270932


More information about the core-libs-dev mailing list