RFR: 8329251: Print custom truststore/ keystore name [v13]
Alan Bateman
alanb at openjdk.org
Thu Dec 5 14:13:41 UTC 2024
On Wed, 27 Nov 2024 14:39:31 GMT, Prasadrao Koppula <pkoppula at openjdk.org> wrote:
>> Using SharedSecrets, I attempted to expose FileInputStream::path information. After implementing the fix, I validated the startup performance tests. Observed no consistent pattern of performance drops or gains, can disregard the occasional performance drop observed in 1 or 2 runs.
>
> Prasadrao Koppula has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>
> - Merge master
> - cache the InputStream in KeyStore
> - Copyright year
> - Merge master
> - initialized storeName with empty string
> - Replaced Paths.get with Path.of
> - Removed unnecessary code
> - Removed unnecessary code
> - Handled nested wrappers around FileInputStream
> - Handled BIS case as well
> - ... and 4 more: https://git.openjdk.org/jdk/compare/96388be1...83043beb
Would it possible to list down the API entry points where you want map the InputStream back to its source? I assume methods such as KeyStore.getInstance(File file, ..) are not a concern, is it the load(InputStream,password) method? I'm puzzled why this PR is only concerned with FIS as there many ways to get an input stream to a file or other source that won't be handled.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20414#issuecomment-2520434562
More information about the core-libs-dev
mailing list