RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided [v2]

Henry Jen henryjen at openjdk.org
Thu Dec 5 17:09:47 UTC 2024


> Improving option value handling to support passing argument value starts with "--".
> 
> Before the fix, in following example, --add-modules will be considered as another option for JLink instead of argument value for --add-options.
> --add-options --add-modules=jdk.incubator.concurrent
> --add-options=--add-modules=jdk.incubator.concurrent
> 
> will cause JLink to report
> Error: no value given for --add-options
> as --add-modules is considered another option for JLink.
> 
> After the fix, by using = will ensure the value is properly handled as argument value. Also using "" with multiple values will be recognized properly. So following form should work
> --add-options "--add-modules jdk.incubator.concurrent"
> --add-options=--add-modules=jdk.incubator.concurrent

Henry Jen has updated the pull request incrementally with one additional commit since the last revision:

  Fix style

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22526/files
  - new: https://git.openjdk.org/jdk/pull/22526/files/70b5f9f5..7dbc99f9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22526&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22526&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/22526.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22526/head:pull/22526

PR: https://git.openjdk.org/jdk/pull/22526


More information about the core-libs-dev mailing list