RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided [v2]

Mandy Chung mchung at openjdk.org
Thu Dec 5 17:42:45 UTC 2024


On Thu, 5 Dec 2024 17:31:24 GMT, Henry Jen <henryjen at openjdk.org> wrote:

>> test/jdk/tools/jlink/TaskHelperTest.java line 115:
>> 
>>> 113:             { "--raw-arg-plugin", "--main-no-arg --list", "--main-no-arg"},
>>> 114:             { "--raw-arg-plugin", " --main-no-arg", "--main-no-arg" },
>>> 115:         };
>> 
>> Skimming on the test, I don't see validation of the parsed parameter values.  I expect the test should also verify.
>
> Line 126 validate the argument is processed.

I expect it should check for the expected value rather than just `--main-no-arg` to catch bug like if the value contains multiple values but only returns one.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22526#discussion_r1871818600


More information about the core-libs-dev mailing list