RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

Scott Marlow duke at openjdk.org
Thu Dec 5 19:36:37 UTC 2024


On Thu, 5 Dec 2024 19:05:07 GMT, Scott Marlow <duke at openjdk.org> wrote:

>> Created a JBS issue https://bugs.openjdk.org/browse/JDK-8345614 for you.
>
>> Created a JBS issue https://bugs.openjdk.org/browse/JDK-8345614 for you.
> 
> I'll force push once more to rename the commit to issue reference the ^ issue.  Thank you @liach for creating that!

> @scottmarlow FYI you can have whatever number of commits with whatever name you like. OpenJDK bot generates a patch as if with `git merge --squash` and commits that patch with the correct issue title as the message, and with the correct commit email.
> 
> Also, I think the issue title I have chosen is more descriptive than your current title. This specific case happens when there are duplicate annotation interfaces, and "container" isn't a good term for the class file that ships the annotation - it might be confused for repeatable annotation containers.

Makes sense, I'll update the title.  I was trying to make the pre-check failure go away.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22581#issuecomment-2521238476


More information about the core-libs-dev mailing list