RFR: 8344168: Change Unsafe base offset from int to long [v4]

Shaojin Wen swen at openjdk.org
Thu Dec 5 23:13:39 UTC 2024


On Tue, 26 Nov 2024 18:05:44 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> The type of the Unsafe base offset constant is int, which may cause overflow when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027) fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are still unfixed.
>> 
>> @liach proposed the idea of ​​changing the Unsafe base offset to long, which is a complete solution to the Unsafe offset overflow. After discussing with @liach, I submitted this PR to implement @liach's idea.
>
> Shaojin Wen has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Typos
>  - Fix type expectations
>  - Make base offset method and invalid offset long

JDK 25 has been launched, please help to continue reviewing this PR

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22095#issuecomment-2521691956


More information about the core-libs-dev mailing list