RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces
Chen Liang
liach at openjdk.org
Thu Dec 5 23:30:39 UTC 2024
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow <duke at openjdk.org> wrote:
> I am getting the `Duplication annotation for class` error as mentioned in https://hibernate.atlassian.net/browse/HHH-18901. The current error message does not include the application class name (e.g. container) that the specified annotation is unexpectedly duplicated. This pull request is for including the class name that has the (duplicate) annotation.
Tested locally with the test I wrote; looks good.
I think we will merge this into JDK 25; please give it 24 hours for everyone to review after your latest push.
Once this is integrated, if you want to get this into JDK 24 (already forked from mainline, in RDP 1), you have to work with an OpenJDK author to file a late enhancement request https://openjdk.org/jeps/3#Late-Enhancement-Request-Process, and to backport to versions like 21, you also need an OpenJDK author to make a fix request https://openjdk.org/projects/jdk-updates/approval.html. For ease of backports, I do not require to add the test I used into the patch.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22581#pullrequestreview-2483218326
More information about the core-libs-dev
mailing list